Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

V10.11.0 proposal #602

Merged
merged 119 commits into from
Sep 21, 2018
Merged

V10.11.0 proposal #602

merged 119 commits into from
Sep 21, 2018

Conversation

kfarnung
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

targos and others added 30 commits September 6, 2018 23:53
@targos
Working on v10.10.1
7c831b7 
PR-URL: nodejs/node#22716
@BridgeAR @targos
util: add util.types.isBoxedPrimitive
8cfa88a 
Checking all boxed primitives individually requires to cross the C++
barrier multiple times besides being more complicated than just a
single check.

PR-URL: nodejs/node#22620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @targos
doc: add apapirovski to TSC
47acb78 
PR-URL: nodejs/node#22717
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott @targos
tools: update dmn to 2.0.0
ca06e65 
New version of dmn with better support for case-sensitive file systems.
Use it in the update-* scripts.

PR-URL: nodejs/node#22733
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@cjihrig @targos
doc: add warning to readline's close() method
688d01c 
When close() is called on a readline instance, it is possible
that data is already buffered, and will trigger 'line' events.
This commit adds a warning to the corresponding docs. Note that
a similar warning already exists for the pause() method.

PR-URL: nodejs/node#22679
Fixes: nodejs/node#22615
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@psmarshall @targos
deps: backport detailed line info for CPU profiler
6a33399 
[cpu-profiler] Add flag to always generate accurate line info.
https://chromium.googlesource.com/v8/v8/+/
56baf56790de439b3f69e887e94beb3b301ed77c

[cpu-profiler] Turn on detailed line info for optimized code
https://chromium.googlesource.com/v8/v8/+/
84894ce6d2af7feb9e1f5574409355120887326c

[cpu-profiler] Separate the flags for generating extra line information
https://chromium.googlesource.com/v8/v8/+/
30ff6719db441cc7ef220d449970cc169067e256

PR-URL: nodejs/node#22688
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen @targos
errors: decapitalize PBKDF2 error
2cb01f0 
PR-URL: nodejs/node#22687
Refs: nodejs/node#20816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@mcollina @targos
doc: added symbols guidelines
2b49b43 
PR-URL: nodejs/node#22684
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@addaleax @targos
test: fix flaky addons/callback-scope/test-resolve-async
1ce9416 
Fixes: nodejs/node#22668
PR-URL: nodejs/node#22664
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@AndreasMadsen @targos
src: fix trace-event-file-pattern description
44f1438 
PR-URL: nodejs/node#22690
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos
deps: patch V8 to 6.8.275.32
e85aa19 
PR-URL: nodejs/node#22682
Refs: v8/v8@6.8.275.30...6.8.275.32
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
test: remove usage of deprecated V8 APIs in addons
13b8011 
PR-URL: nodejs/node#22704
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack @targos
build: rename configure to configure.py
db52f8f 
!Should go with next commit!

* renaming so that IDEs can properly detect this as python
* Add dependency to Makefile

PR-URL: nodejs/node#22450
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@refack @targos
build: move meta-shebang back to configure
db10db9 
PR-URL: nodejs/node#22450
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@refack @targos
build: add --verbose to ./configure
5bae8b9 
PR-URL: nodejs/node#22450
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@chakravarthy-s-m @targos
doc: fix typo in CHANGELOG_V10.md
e5cdfb0 
Fix typo

PR-URL: nodejs/node#22744
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@BridgeAR @targos
doc: improve assert documentation
c1c78ca 
This fixes the officially accepted message types for `assert.throws()`,
`assert.rejects()`, `assert.doesNotThrow()` and
`assert.doesNotReject()`. It also renames the `block` argument in
those functions to `fn` and `promiseFn` for further clarity.

PR-URL: nodejs/node#22692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@tniessen @targos
build: make doc generation work on Windows
a78a946 
PR-URL: nodejs/node#22749
Refs: nodejs/node#21697
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen @targos
doc: fix description of DEP0024
6579d05 
PR-URL: nodejs/node#22755
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@rubys @targos
tools: add [src] links to child-process.html
a7e8949 
handle exports. as an alternative to module.exports

PR-URL: nodejs/node#22706
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
test: replaces assert.throws() with common.expectsError()
3666662 
replaces assert.throws() with common.expectsError() to check error code
and error type in parallel/test-buffer-alloc.js

PR-URL: nodejs/node#22689
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danbev @targos
src: remove abort_on_uncaught_exception node.cc
c3c5141 
This commit removes the static variable abort_on_uncaught_exception and
adds it to the environment options.

PR-URL: nodejs/node#22724
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Hariss096 @targos
test: remove string argument to strictEqual()
649288b 
Removing string literal passed as argument to assert.strictEqual() in
order to print the expected value instead of the string. (First issue
assigned through Email by Rich Trott)

PR-URL: nodejs/node#22718
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev @targos
src: remove trace_sync_io_ from env
7fa5f54 
This commit removes trace_sync_io_ and instead uses the options value
directly.

PR-URL: nodejs/node#22726
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@skelliam @targos
build: remove /MP from default additonal options
3ff425e 
PR-URL: nodejs/node#22661
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@mmarchini @targos
doc: update mmarchini's e-mail
9942117 
PR-URL: nodejs/node#22776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@kfarnung @targos
tools,doc: apilinks should handle root scenarios
649fcbb 
* Prevent crash when setting root properties
* Allow return outside of function

PR-URL: nodejs/node#22721
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@iliashkolyar @targos
test: remove string literal from deepStrictEqual
d5e9801 
PR-URL: nodejs/node#22742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@addaleax @targos
src: make FIXED_ONE_BYTE_STRING an inline fn
0c32428 
This prevents accidental usage on non-fixed strings.

PR-URL: nodejs/node#22725
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@starkwang @targos
net: port isIPv6 to JS
4e3f1ae 
Porting isIPv6() to JS makes it 10%-250% faster in most cases and
reduces some C++ code. This change also adds tests for some edge
cases.

PR-URL: nodejs/node#22673
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Roman Reiss <me@silverwind.io>
Trott and others added 21 commits September 20, 2018 08:09
@Trott @targos
test: refactor flag check
a5f7f1d 
Refactor test-vm-run-in-new-context so that check for `--expose-gc` flag
will not run afoul of an upcoming lint rule that checks that string
literals are not used for the `message` argument of
`assert.strictEqual()`.

Backport-PR-URL: nodejs/node#22912
PR-URL: nodejs/node#22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott @targos
test: remove string literal from assertion
266f1a9 
Remove string literal from `assert.strictEqual()` call `message`
parameter and make it a comment above the assertion instead.

Backport-PR-URL: nodejs/node#22912
PR-URL: nodejs/node#22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott @targos
test: remove string literal message from assertion
59b6968 
Remove string literal from assert.strictEqual message to improve output
of AssertionError.

Backport-PR-URL: nodejs/node#22912
PR-URL: nodejs/node#22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott @targos
test: remove string literal arg from assertion
5316334 
Remove unnecessary string literal from assert.deepStrictEqual() call.

Backport-PR-URL: nodejs/node#22912
PR-URL: nodejs/node#22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott @targos
test: remove string literal from assertion
5d4cbd7 
Remove string literal as assertion message in call to
assert.strictEqual() in test-dns-resolveany-bad-ancount.

Backport-PR-URL: nodejs/node#22912
PR-URL: nodejs/node#22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott @targos
test: remove string literal from assertion
5a06326 
Remove string literal as assertion message in call to
assert.strictEqual() in test-dns-lookup.

Backport-PR-URL: nodejs/node#22912
PR-URL: nodejs/node#22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott @targos
test: prepare test-assert for strictEqual linting
ff6e4ea 
Make minor modifications to test-assert.js to prepare it for linting
rule that forbids the use of string literals for the third argument of
assert.strictEqual().

Backport-PR-URL: nodejs/node#22912
PR-URL: nodejs/node#22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott @targos
tools: prevent string literals in some assertions
8ffcb2d 
String literals provided as the third argument to assert.strictEqual()
or assert.deepStrictEqual() will mask the values that are causing
issues. Use a lint rule to prevent such usage.

Backport-PR-URL: nodejs/node#22912
PR-URL: nodejs/node#22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Drieger @targos
deps: cherry-pick 9a23bdd from upstream V8
5660759 
Original commit message:

    [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames

    Previously we were getting the code object from the stack, so printed incorrect
    position details for interpreted frames.

    BUG=v8:7916

    Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
    Reviewed-on: https://chromium-review.googlesource.com/1126313
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54253}

Refs: v8/v8@9a23bdd
Refs: nodejs/node#21988
PR-URL: nodejs/node#22910
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
lib,doc: remove unused parameter, improve docs
25220f0 
1) Remove 'callback' in 'check' function, because we don't check or use
that directly.

2) Make 'digest' clearer in the documentation.

PR-URL: nodejs/node#22858
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott @targos
tools: synchronize deepStrictEqual() message rules
6367349 
Update ESLint config to include a rule about assert.deepStrictEqual()
messages and string literals. The rule is included in lib and test, but
should be included everywhere else as well.

PR-URL: nodejs/node#22887
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@isurusiri @targos
doc: explain how to invoke gc
6ed5845 
Currently the documentation for Wrapping C++ Objects doesn't explain
how to destruct an object by explicitly invoking the garbage collector.
This commit includes a modification to docs that explains how to force
the garbage collector to clear objects using V8's command line flags.

Fixes: nodejs/node#19876

PR-URL: nodejs/node#20431
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
@bzoz @targos
doc, win: improve os.setPriority documentation
5da1f0c 
PR-URL: nodejs/node#22817
Fixes: nodejs/node#22799
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos
2018-09-20, Version 10.11.0 (Current)
8c70b20 
Notable changes:

* fs
  * Fixed fsPromises.readdir `withFileTypes`.
    nodejs/node#22832
* http2
  * Added `http2stream.endAfterHeaders` property.
    nodejs/node#22843
* util
  * Added `util.types.isBoxedPrimitive(value)`.
    nodejs/node#22620
* Added new collaborators:
  * boneskull (https://github.com/boneskull) - Christopher Hiller
* The Technical Steering Committee has new members:
  * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski
  * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof

PR-URL: nodejs/node#22932
@kfarnung
deps: update ChakraCore to chakra-core/ChakraCore@a457e9ec51
c878aa5 
[MERGE #5687 @kfarnung] [Backport #5464] update the build script to support LLVM > 9

Merge pull request #5687 from kfarnung:macclang

Backporting #5464 to release/1.11, thanks again to @patrickkettner for the PR.

Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
@MikeHolman @kfarnung
deps: update ChakraCore to chakra-core/ChakraCore@1987607195
bd456ae 
[1.10>1.11] [MERGE #5688 @MikeHolman] September 2018 Security Update

Merge pull request #5688 from MikeHolman:servicing/1809

September 2018 Security Update that addresses the following issues in ChakraCore:

CVE-2018-8315
CVE-2018-8354
CVE-2018-8367
CVE-2018-8452
CVE-2018-8456
CVE-2018-8459
CVE-2018-8465
CVE-2018-8466
CVE-2018-8467

Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
@VSadov @kfarnung
deps: update ChakraCore to chakra-core/ChakraCore@0e9faf246c
11431a2 
[MERGE #5683 @VSadov] Do not lose property string in ToPropertyKey

Merge pull request #5683 from VSadov:propString

Looks like the intent of the method is to set propString to a property string if the argument happen to be one. It does not do that now. Possibly due to a typo.

In particular, methods such as HasOwnProperty check if propString is returned and would use its inline caches, but since the property string is not returned, the optimization cannot work.

Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
@dilijev @kfarnung
deps: update ChakraCore to chakra-core/ChakraCore@cd45bae233
d7670c6 
[MERGE #5691 @MSLaguana] Bumping version prior to release v1.11.1

Merge pull request #5691 from MSLaguana:bumpVersion

Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
@kfarnung
chakrashim,test: add missing API
99bdf0e 
* Added `V8InspectorClient::resourceNameToUrl`
* Skipped a new worker test
@kfarnung
chakrashim: enable resourceNameToUrl support
9493df4 
Wired up support for calling the node-provided `resourceNameToUrl`
method in the chakrashim inspector.

This reverts commit 3f6ef13.

PR-URL: nodejs#601
Fixes: nodejs#598
Refs: nodejs/node#22251
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
@kfarnung
chakrashim: add missing API
c0929d6 
Implemented the `Context::GetNumberOfEmbedderDataFields` API.
@kfarnung kfarnung self-assigned this Sep 20, 2018
@kfarnung
Copy link
Contributor Author

kfarnung commented Sep 20, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/326/

kfarnung and others added 4 commits September 20, 2018 16:45
@kfarnung
Merge tag 'v10.11.0' into v10.11.0-proposal
0062983 
2018-09-20 Node.js v10.11.0 (Current) Release
Git-EVTag-v0-SHA512: c58ff08d7b7cd6dd83662e65081904f2d993b0aa34d91ec3c95dddb887195548b9471ff0f71e79a17ee2c6afc71651196848ffb113c4ea7468c7dba99e71b88c
@kfarnung
Fixed or skipped failing tests
7f9687a
@kfarnung
n-api,test: stub out function
b9868fd 
There isn't a clean way to implement `napi_add_finalizer` in ChakraCore
so just fix the addon build and skip the test for now.

PR-URL: nodejs#596
Reviewed-By: Seth Brenith <sethb@microsoft.com>
@kfarnung
test: skip new incompatible test
e0fdb65
@kfarnung kfarnung merged commit e0fdb65 into nodejs:v10.x Sep 21, 2018
@kfarnung kfarnung deleted the v10.11.0-proposal branch September 21, 2018 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kfarnung kfarnung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet