Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-v8: add abseil-cpp as a V8 dependency #565

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Conversation

richardlau
Copy link
Member

Add new V8 dependency introduced in V8 9.6.

Refs: nodejs/node-v8#211

cc @targos @nodejs/v8-update

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #565 (99460db) into main (35d281b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files          35       35           
  Lines        1750     1750           
=======================================
  Hits         1445     1445           
  Misses        305      305           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d281b...99460db. Read the comment docs.

Add new V8 dependency introduced in V8 9.6.
@targos targos merged commit 96d46ab into nodejs:main Sep 25, 2021
@targos
Copy link
Member

targos commented Sep 29, 2021

https://github.com/nodejs/node-v8/runs/3740771276?check_suite_focus=true

[06:04:01] → Cannot read property 'split' of undefined
[06:04:01] Major V8 update [failed]
✖ Cannot read property 'split' of undefined
[06:04:01] → Cannot read property 'split' of undefined

Looks like they're having issues with this dependency and removed it for now: v8/v8@67601ba

@richardlau
Copy link
Member Author

@targos Should we revert this then to fix the canary workflow?

@targos
Copy link
Member

targos commented Sep 29, 2021

Let's wait a couple of days to see if they reland it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants