Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add releaseDate to json #796

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Apr 14, 2024

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, we need to check if a valid date is given, if not it should leave it empty. For instance, TBD.

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Apr 16, 2024

actually, we need to check if a valid date is given, if not it should leave it empty. For instance, TBD.

if invalid date is given it will throw right now

@RafaelGSS
Copy link
Member

actually, we need to check if a valid date is given, if not it should leave it empty. For instance, TBD.

if invalid date is given it will throw right now

But, what if we don't have a target date? I would like to pass TBD

@marco-ippolito
Copy link
Member Author

ok so I'll validate only if different from 'TBD'

@RafaelGSS RafaelGSS merged commit b5d99ca into nodejs:main Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants