-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
requested by jshttp/mime-db#88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Arguably out of scope for this document, but if people are looking to us for the answer on MIME type, this is certainly the answer I'd expect us to give. So 👍 |
The first part looks good:
But I'm not sure about this
because I don't know what's going on the Perhaps /cc @domenic for that. Note that I'm not implying that I prefer to see |
@ChALkeR we could remove the second sentence? |
@bmeck I guess we could, this change would make sense even without mentioning the preferred one of those. That addition of the preferred mime has its value, so if the decision could be made in a reasonable amount of time to favor one of those for some valid reasons, so I would prefer it to be mentioned, but if that won't be achieved — merging this without an exact preferred mimetype LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but either after elaborating (not in the patch itself, but in GitHub comments and/or commit comment) why should the mentioned preferred exact type (whatever it would be) be preferred, or with removing the «preferred» part if there would be no informed decision on that in a reasonable time.
text/javascript is preferred on the web generally; I believe some RFC tried to obsolete it, but it's the most prevalent on the web, so the HTML spec just made it the default. |
linked to HTML spec and updated |
@bmeck I am still not entirely sure if the HTML spec is the correct source for this. |
|
I dunno. HTML is the spec for web browsers, and web browsers are the major client that (a) cares about MIME types and (b) executes JavaScript. So I think it's a pretty good place for it. |
I would agree with @domenic here |
@ChALkeR are you ok with |
landed in 6eef91d |
No description provided.