Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping -I includes when path contains spaces #1038

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

salomvary
Copy link

Fixes #65

@jure
Copy link

jure commented Jul 21, 2017

We've been hit by this issue today and were quite surprised to discover it's an ancient bug in node-gyp. Any reason why this can't be merged and #65 fixed?

@bnoordhuis
Copy link
Member

Hadn't seen this until today but it's at best a partial fix for #65. I didn't do a full audit but things like linker paths and source lists are also affected and probably more.

@jure
Copy link

jure commented Jul 22, 2017

Thanks for looking at this! Unless the partial fix breaks something else, and it doesn't seem likely, perhaps it's a good step into the direction of supporting spaces in build paths? The alternative could be a clear notice somewhere in the README, noting the lack of support.

@elmagow
Copy link

elmagow commented Nov 9, 2018

Any news about this? I can't install gyp because I have a space in my hdd name

@rvagg
Copy link
Member

rvagg commented Jun 21, 2019

@refack should we pursue this here or https://github.com/refack/GYP, I don't even know anymore

@Schwaller
Copy link

Please get this space thing fixed - super annoying if testing infrastructure contains spaces ... u know to test stability for spaces :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure when builddir contains spaces.
6 participants