Chore: Header-ify the Install instructions #1225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable linking to the platform specific installation instructions
refack
approved these changes
Jun 6, 2017
|
|
||
| * Option 2: Install [Visual Studio 2015](https://www.visualstudio.com/products/visual-studio-community-vs) (or modify an existing installation) and select *Common Tools for Visual C++* during setup. This also works with the free Community and Express for Desktop editions. | ||
|
|
||
| > :bulb: [Windows Vista / 7 only] requires [.NET Framework 4.5.1](http://www.microsoft.com/en-us/download/details.aspx?id=40773) |
There was a problem hiding this comment.
I like the 💡 but it's a GitHub only feature.
IMHO you could put *Note*: like was set in node core nodejs/node#13133
There was a problem hiding this comment.
That was already there as I only re-indented the lists https://github.com/nodejs/node-gyp/pull/1225/files?w=1
I can change that in this if you want though
There was a problem hiding this comment.
Let's wait for other people to chime in...
|
@nschonni thank you for doing this. Good idea 🥇 |
refack
pushed a commit
to refack/node-gyp
that referenced
this pull request
Jun 11, 2017
Enable linking to the platform specific installation instructions PR-URL: nodejs#1225 Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in 35e1dbb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable linking to the platform specific installation instructions.
The initial heading levels were changed since it was goin h1->h3 for the subheading