Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation of #1492 ("bump request to 2.87.0") #1521

Closed
wants to merge 3 commits into from

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Aug 8, 2018

It's a shame that #1492 got mired in v0.10 support, it would have been so much easier to just ignore it! I don't even have an easy v0.10 at hand to test that it even works; although I have tried it out with var execFileSync = require('./process-exec-sync') and it works.

Anyway, this pulls in #1492 with a squash and a patch to make the code consistent with the codebase, fix a bunch of nits and a bug that was causing the test to fail on my Linux machine (a problem with 'node' not properly in PATH).

Happy to get this published asap, just need some eyes on changes first.

@rvagg rvagg mentioned this pull request Aug 8, 2018
2 tasks
Copy link
Contributor

@Rohithzr Rohithzr left a comment

LGTM

@maclover7
Copy link
Member

@maclover7 maclover7 commented Aug 8, 2018

@brodybits
Copy link

@brodybits brodybits commented Aug 8, 2018

Do you guys have an ETA on merge and publish?

@rvagg rvagg mentioned this pull request Aug 8, 2018
2 tasks
rvagg added a commit that referenced this issue Aug 9, 2018
PR-URL: #1521
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg added a commit that referenced this issue Aug 9, 2018
PR-URL: #1521
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg
Copy link
Member Author

@rvagg rvagg commented Aug 9, 2018

merged & published in v3.8.0

@rvagg rvagg closed this Aug 9, 2018
@rvagg rvagg deleted the rvagg/execFileSync-cleanup branch Aug 9, 2018
@brodybits
Copy link

@brodybits brodybits commented Aug 9, 2018

Thank you @rvagg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants