-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: use print() for python version detection #1534
Conversation
Hello @greenaddress, and thank you for the contribution.
|
cdb1568
to
eaff2a9
Compare
@refack done, thank you for review! |
@greenaddress thank you for following up. We'll land this soon, then we need to release a new version and get that landed in |
Still happening 5 months later.. |
Since this seems to be a very common error (countless forum posts and issues / who has Python 2 installed nowadays?) this should have been integrated into a package release by now. The last NPM release of |
I am still facing this issue, when this bug fix will be released. |
The last time an update was release 7 months ago, can you release the a new update with all the bug fixes |
I don't have permissions to publish this to npm. |
😮 Oh! Okay |
PR-URL: #1534 Reviewed-By: Refael Ackermann <refack@gmail.com>
What versions did this go into? I'm on 10.16 and 6.10 and seeing this message? |
|
This fixes an issue introduced by commit da5db40 specifically this line da5db40#diff-7ad6309831a48a234780b58baca65710R440
Namely, the bit that checks for python versions was changed and went from supporting both python2 and python3 to supporting only python2.
I understand there are other open issues/PRs in regards to python3 but this change specifically is a regression that broke windows builders with python3 in the path as python.