Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: use msbuild from the configure stage #1654

Merged
merged 1 commit into from Feb 13, 2019

Conversation

@bzoz
Copy link
Contributor

commented Jan 22, 2019

Checklist
Description of change

If node-gyp configure has set up MSBuild location use it instead the one that happens to be first on the PATH.

Fixes: #1653

If node-gyp configure has set up MSBuild location use it instead the
one that happens to be first on the PATH.

Fixes: #1653
@richardlau richardlau added the Windows label Jan 22, 2019
@refack
refack approved these changes Jan 22, 2019
@refack

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

@bzoz thanks for the fix. Could you add a test? (maybe run node-gyp configure then add a fake msbuild.exe to the path and run node-gyp build)

@joaocgreis

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/115/ ✔️

@refack do you mind if I land this even without the test? Change here is pretty straightforward and there was no test before.

@refack refack merged commit 770b397 into nodejs:master Feb 13, 2019
@refack

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@joaocgreis, done.

refack added a commit to refack/node-gyp that referenced this pull request Feb 13, 2019
If node-gyp configure has set up MSBuild location use it instead the
one that happens to be first on the PATH.

PR-URL: nodejs#1654
Fixes: nodejs#1653
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
rvagg added a commit that referenced this pull request Apr 24, 2019
If node-gyp configure has set up MSBuild location use it instead the
one that happens to be first on the PATH.

PR-URL: #1654
Fixes: #1653
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@rvagg rvagg referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.