Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: move compile_commands_json #1661

Closed

Conversation

@marechal-p
Copy link
Contributor

commented Feb 6, 2019

It isn't possible to access
tools/gyp/pylib/gyp/generator/compile_commands_json.py using the
--format option.

This commit moves the file in a place where it can be accessed.

Fixes: #1526

Signed-off-by: Paul Maréchal paul.marechal@ericsson.com

Checklist
Description of change

Should allow us to use the compile_commands_json formatter/generator.

It isn't possible to access
`tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the
`--format` option.

This commit moves the file in a place where it can be accessed.

Fixes: #1526

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
@marechal-p

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

If I missed something and this change isn't actually required, please tell me :)

Copy link
Member

left a comment

LGTM, thanks.

In case you're wondering: this file was brought over from nodejs/node@3c46bb9 where gyp lives in tools/gyp. :-)

bnoordhuis added a commit that referenced this pull request Feb 12, 2019
It isn't possible to access
`tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the
`--format` option.

This commit moves the file in a place where it can be accessed.

Fixes: #1526
PR-URL: #1661
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Landed in 2349dba, thanks Paul.

@bnoordhuis bnoordhuis closed this Feb 12, 2019
@marechal-p marechal-p deleted the marechal-p:mp/move_compile_commands_json branch Feb 13, 2019
rvagg added a commit that referenced this pull request Apr 24, 2019
It isn't possible to access
`tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the
`--format` option.

This commit moves the file in a place where it can be accessed.

Fixes: #1526
PR-URL: #1661
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
@rvagg rvagg referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.