Fix running Windows on Travis CI #1812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Jul 7, 2019
bzoz
approved these changes
Jul 8, 2019
test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Fixes: nodejs#1801
Test the oldest supported Node version on Windows.
joaocgreis
force-pushed
the
joaocgreis-J77-win-travis
branch
from
3f3bb7b
to
584e7bb
Compare
3 tasks
|
I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied anyway, this is reasonable I think, +1 |
richardlau
approved these changes
Jul 9, 2019
|
travis_wait might be worth considering. But perhaps not. |
joaocgreis
added a commit
that referenced
this pull request
Jul 9, 2019
test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Fixes: #1801 PR-URL: #1812 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
joaocgreis
added a commit
that referenced
this pull request
Jul 9, 2019
Test the oldest supported Node version on Windows. PR-URL: #1812 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in 656117c...bb92c76, thanks. @richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
test-addon.jsincludes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.
Fixes: #1801
cc @cclauss