v5.x Python compat fixes for README #1911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 is allowed as a compatible Python, but its looked for after Python 2. rvagg: removed additional EXPERIMENTAL_NODE_GYP_PYTHON3 in .travis.yml from a previous commit while landing. Backport-of: #1844 PR-URL: #1910 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #1904 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Clarify that: - node-gyp is not used to build Node.js - PYTHON can be used to add a Python search path - NODE_GYP_FORCE_PYTHON can be used to override all Python search paths - That a compatible Python is searched for PR-URL: #1908 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
added fixup commit to bring back 2.6 support in docs ... will need to do another PR to bring it back in find-python.js |
sam-github
approved these changes
Oct 4, 2019
|
removed mention of 2.6 in here, it's only "supported" in the sense the our |
rvagg
added a commit
that referenced
this pull request
Oct 4, 2019
PR-URL: #1911 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
|
landed in v5.x as 3891391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When backporting #1908 I noticed that it leaves README in a weird 1/2 way state, still stating that it needs Python 2.7.
This PR adds #1908 plus additional changes required to make README match master. I don't believe there's anything different that needs to be said between the two at this stage.
The only minor difference is in the initial list of requirements,
masterhas "Python v2.7, v3.5, v3.6, or v3.7", this one just has "Python v2.7, v3.5, v3.6, or v3.7" (no backticks). I'll PR that to master.@cclauss @joaocgreis @sam-github any of you around to +1 this so I can get a 5.0.5 out with it?