Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add macOS_Catalina.md document #1940

Closed
wants to merge 9 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 25, 2019

Document the lessons learned from #1779, #1861, #1927 and elsewhere to
enable users to consistently install node-gyp on macOS Catalina (v10.15).

@AshCripps Your review please.

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

richardlau and others added 2 commits October 24, 2019 14:54
The servers hosting the header packages for Electron return 403
instead of 404 for the constructed URL for arm64 node.lib for
older releases that do not support arm64.

PR-URL: nodejs#1934
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
8. `sudo xcode-select --reset` # Enter root password. No output is normal.
9. Repeat step 5 above. Is the path different this time? Repeat the _acid test_.

### I did all that and the acid test still does not pass :-(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me! Thank you :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I please get your review on this PR?

@rvagg
Copy link
Member

rvagg commented Oct 30, 2019

Two things I wouldn't mind seeing: a link from the README pointing out its existence (otherwise this will be ignored) and a TTL at the top of the doc, maybe something like this in italics:

This document specifically refers to upgrades from previous versions of macOS to Catalina (10.15). It should be removed from the source repository when Catalina ceases to be the latest macOS version or updated to deal with challenges involved in upgrades to the next macOS version.

An obvious signal for whoever's running this project in a ~year. Otherwise it's pure cruft making a mess in the root directory.

9. Repeat step 5 above. Is the path different this time? Repeat the _acid test_.

### I did all that and the acid test still does not pass :-(
1. `sudo rm -rf $(xcode-select -print-path)` # Enter root password. No output is normal.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually worked for me, thnx!

@gengjiawen
Copy link
Member

Maybe put in directory troubleshooting in case we have other similar problem ?

macOS_Catalina.md Outdated Show resolved Hide resolved
Co-Authored-By: Ted Morin <morinted@gmail.com>
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, anyone else have an opinion before we merge?

### Two roads
There are two main ways to install `node-gyp` on macOS:
1. With the full Xcode (~7.6 GB download) from the `App Store` app.
2. With the _much_ smaller Xcode Command Line Tools via `xcode-select -install`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a "-" missing in "xcode-select -install"

rvagg pushed a commit that referenced this pull request Nov 1, 2019
PR-URL: #1940
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@rvagg
Copy link
Member

rvagg commented Nov 1, 2019

fixed, squashed and merged in 8ec2e68

@rvagg rvagg closed this Nov 1, 2019
rvagg pushed a commit that referenced this pull request Nov 18, 2019
PR-URL: #1940
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@cclauss cclauss deleted the notes-on-macOS-Catalina.md branch June 23, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants