-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add macOS_Catalina.md document #1940
Conversation
The servers hosting the header packages for Electron return 403 instead of 404 for the constructed URL for arm64 node.lib for older releases that do not support arm64. PR-URL: nodejs#1934 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: João Reis <reis@janeasystems.com>
8. `sudo xcode-select --reset` # Enter root password. No output is normal. | ||
9. Repeat step 5 above. Is the path different this time? Repeat the _acid test_. | ||
|
||
### I did all that and the acid test still does not pass :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me! Thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I please get your review on this PR?
Two things I wouldn't mind seeing: a link from the README pointing out its existence (otherwise this will be ignored) and a TTL at the top of the doc, maybe something like this in italics:
An obvious signal for whoever's running this project in a ~year. Otherwise it's pure cruft making a mess in the root directory. |
9. Repeat step 5 above. Is the path different this time? Repeat the _acid test_. | ||
|
||
### I did all that and the acid test still does not pass :-( | ||
1. `sudo rm -rf $(xcode-select -print-path)` # Enter root password. No output is normal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually worked for me, thnx!
Maybe put in directory |
Co-Authored-By: Ted Morin <morinted@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, anyone else have an opinion before we merge?
macOS_Catalina.md
Outdated
### Two roads | ||
There are two main ways to install `node-gyp` on macOS: | ||
1. With the full Xcode (~7.6 GB download) from the `App Store` app. | ||
2. With the _much_ smaller Xcode Command Line Tools via `xcode-select -install` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a "-" missing in "xcode-select -install"
PR-URL: #1940 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
fixed, squashed and merged in 8ec2e68 |
PR-URL: #1940 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Document the lessons learned from #1779, #1861, #1927 and elsewhere to
enable users to consistently install
node-gyp
on macOS Catalina (v10.15).@AshCripps Your review please.
Checklist
npm install && npm test
passesDescription of change