Override BUILDING_UV_SHARED, BUILDING_V8_SHARED. #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Seems correct |
|
LGTM |
We were inheriting BUILDING_UV_SHARED and BUILDING_V8_SHARED from the common.gypi from the node.js source tree. Override them with USING_UV_SHARED and USING_V8_SHARED so symbols get tagged with `__declspec(dllimport)` instead of `__declspec(dllexport)`, which is the desired attribute when building add-ons. Fixes: #914 PR-URL: #915 Reviewed-By: Benjamin Byholm <bbyholm@abo.fi> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were inheriting BUILDING_UV_SHARED and BUILDING_V8_SHARED from
the common.gypi from the node.js source tree. Override them with
USING_UV_SHARED and USING_V8_SHARED so symbols get tagged with
__declspec(dllimport)instead of__declspec(dllexport), whichis the desired attribute when building add-ons.
Fixes: #914