This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
punycode: Update to v1.0.0 (properly this time) #3359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isaacs @bnoordhuis - Can we merge this? I do not know why #2456 was not merged in v0.6, accident or intentional? #2456 (also this patch) changes the API, but the old API has never been documented. If we cannot merge this, I think that #2824 should be reverted (Node v0.6 continues to use punycode.js v0.2.1). |
|
@bnoordhuis - Okay, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 483edbd, which incorrectly updated the version number, but not the API, causing a mismatch between the documentation (a2fcc47) and the actual code.