Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node-update-v8-canary to GitHub Actions #169

Closed
Tracked by #170
mmarchini opened this issue Sep 13, 2020 · 3 comments · Fixed by #171
Closed
Tracked by #170

Move node-update-v8-canary to GitHub Actions #169

mmarchini opened this issue Sep 13, 2020 · 3 comments · Fixed by #171

Comments

@mmarchini
Copy link

With GitHub Actions there's no reason to keep the update script on Jenkins, we can move it here making it easier for folks without Jenkins admin access to help improve it when something breaks.

@targos
Copy link
Member

targos commented Sep 13, 2020

Good idea. I can have a try at it.

@mmarchini
Copy link
Author

I think this will work better if we decide to move forward with #170, but it could be implemented in the current system as well (we would just need to make sure we also cherry-pick the commit adding the Action to this repository when updating V8)

@targos targos self-assigned this Sep 13, 2020
@targos targos linked a pull request Sep 13, 2020 that will close this issue
@targos
Copy link
Member

targos commented Apr 11, 2021

This is live: https://github.com/nodejs/node-v8/actions/runs/737865140

@targos targos closed this as completed Apr 11, 2021
@targos targos removed their assignment Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants