-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N-API test failure #173
Comments
/cc @nodejs/n-api |
I cannot reproduce on my system (CentOS 8, with GCC 8.3.1) |
This did not reproduce on my system either (Ubuntu 18.04.4, GCC 7.5.0) |
I think one of the machines in the build matched the ubuntu/gcc level that I have:
from https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1804-64/37061/consoleFull So maybe we should re-run after the security release to see if it re-occurs |
It's been occuring for some time (I haven't checked when it started to fail). Here's an other example from one week ago: https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/600/ |
So its intermittent or fails every time in the CI ? |
Also to confirm, the job just checks out the canary branch (the default) of node-v8 and does make test ? |
It fails every time in CI. History: https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/ |
Strange since that should match what we've run. I wonder if it would make sense to clear the workspace and make sure it recreates. |
@targos are you ok if we clear the workspace to see if that makes any difference? |
I'm ok |
Ok, have cleared the workspace for https://ci.nodejs.org/job/node-test-commit-node-v8/. We'll see if that makes any difference. |
I can't reproduce this. |
Looks like Ubuntu 16.04 64-bit with gcc-7.5.0. |
Using test-joyent-ubuntu1804-x64-1 on which we saw the failure recently to investigate |
Compiling in directory: https://github.com/nodejs/node-v8.git |
did not recreate with a |
Called set-compiler but not the ccache config still did not recreate, but not much seemed to be compiled either. Having said that it did not seem to have changed the compiler either |
Double checked last failure was on https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1804-64/37204/ |
Remaining thing that is not like ci would be the ccache. Next week I'll create a duplicate job that would only run on the same machine and validate it fails under CI, and if so then try to remove the part of the job which configures ccache. |
Create this job: https://ci.nodejs.org/job/node-test-commit-linux-mhdawson/ as clone of main job which only runs on test-joyent-ubuntu1804-x64-1 and uses node-v8 and the canary branch. Run to see if it recreates: https://ci.nodejs.org/job/node-test-commit-linux-mhdawson/2/console |
Unfortunately that job is not working, need to look further |
Recreated job as https://ci.nodejs.org/job/node-test-commit-linux-mhdawson/, does not default to node-v8/canary, but seems to be running having specified that in the build parameters |
Tried recreating through a clone of the job. Tried the follwing:
|
Looking at the build jobs they look pretty much the same. The only thing I can see is that my new job does not have the |
Still no recreate, the only other thing I can think of trying is to clear the workspace for node-test-commit-linux but that would definitely have an impact on the next run. |
Wiping workspace for |
node-v8 run to see if wiping workspace had any effect: https://ci.nodejs.org/view/All/job/node-test-commit-node-v8/622/ |
second run as first one seems to fail, missing some config after workspace clean https://ci.nodejs.org/job/node-test-commit-node-v8/623/ |
Seems like you have to run 3 times after workspace clear, third one now seems to be building now. |
Looks to me like the linux job on ubuntu 1804 passed in this run: https://ci.nodejs.org/job/node-test-commit-node-v8/624/ |
Lets see if it passes in the next regularly scheduled canary builds, if so it seems like the workspace clean removed whatever was causing the problem. |
Thanks for looking into it @mhdawson ! Here is today's run: https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/626/ |
@targos that link seems to 404 for me. Launched this one https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/628/ |
Ok test_object passed in the last build I started as well. @targos I'm going to close this as I think it's resolved. Please re-open if it recreates. |
https://ci.nodejs.org/job/node-test-commit-linux/37061/nodes=ubuntu1804-64/console
The text was updated successfully, but these errors were encountered: