Permalink
Browse files

buffer: remove Uint8Array check

This makes write[U]Int* operations on Buffer with `noAssert=false` about 3
times faster.

PR-URL: #11324
Refs: #11245
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information...
seishun committed Feb 16, 2017
1 parent bd07c8f commit 00c86cc8e9b5172372571cc122ebeb6d5a7e5e93
Showing with 2 additions and 8 deletions.
  1. +0 −2 lib/buffer.js
  2. +2 −6 test/parallel/test-buffer-write-noassert.js
View
@@ -1056,8 +1056,6 @@ Buffer.prototype.readDoubleBE = function readDoubleBE(offset, noAssert) {
function checkInt(buffer, value, offset, ext, max, min) {
if (!isUint8Array(buffer))
throw new TypeError('"buffer" argument must be a Buffer or Uint8Array');
if (value > max || value < min)
throw new TypeError('"value" argument is out of bounds');
if (offset + ext > buffer.length)
@@ -20,14 +20,10 @@ function write(funx, args, result, res) {
);
}
{
const error = /Int/.test(funx) ?
/^TypeError: "buffer" argument must be a Buffer or Uint8Array$/ :
/^TypeError: argument should be a Buffer$/;
if (!/Int/.test(funx)) {
assert.throws(
() => Buffer.alloc(9)[funx].apply(new Uint32Array(1), args),
error
/^TypeError: argument should be a Buffer$/
);
}

0 comments on commit 00c86cc

Please sign in to comment.