Skip to content
Browse files

build: make linter failures fail `test-doc` target

Linter failures in the `test-doc` make target were not failing the
build if the subsequent `doctools` test passed as its exit code
wasn't being preserved.

Make the `lint` target a dependency of `test-doc` so that it is
outside of the `node_use_openssl` guard -- its own dependencies
have their own guards where necessary and the targets that don't
require an available node (e.g. the C++ linters) will be allowed
to run.

PR-URL: #30012
Reviewed-By: Sam Roberts <>
Reviewed-By: James M Snell <>
Reviewed-By: Colin Ihrig <>
Reviewed-By: Rich Trott <>
Reviewed-By: Daniel Bevenius <>
Reviewed-By: Gireesh Punathil <>
  • Loading branch information
richardlau authored and targos committed Oct 17, 2019
1 parent abfac96 commit 032c23d36072789c44275dbb7177b3d24b28373e
Showing with 1 addition and 2 deletions.
  1. +1 −2 Makefile
@@ -592,11 +592,10 @@ test-hash-seed: all
$(NODE) test/pummel/test-hash-seed.js

.PHONY: test-doc
test-doc: doc-only ## Builds, lints, and verifies the docs.
test-doc: doc-only lint ## Builds, lints, and verifies the docs.
@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
echo "Skipping test-doc (no crypto)"; \
else \
$(MAKE) lint; \
$(PYTHON) tools/ $(PARALLEL_ARGS) doctool; \

0 comments on commit 032c23d

Please sign in to comment.
You can’t perform that action at this time.