util: freeze kEnumerableProperty

PR-URL: #43390 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs · Jul 31, 2022 · 053347c · 053347c
1 parent 705a8af
commit 053347c
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -511,6 +511,7 @@ function structuredClone(value) {
 
 const kEnumerableProperty = ObjectCreate(null);
 kEnumerableProperty.enumerable = true;
+ObjectFreeze(kEnumerableProperty);
 
 const kEmptyObject = ObjectFreeze(ObjectCreate(null));
 

diff --git a/test/parallel/test-internal-util-objects.js b/test/parallel/test-internal-util-objects.js
@@ -29,6 +29,35 @@ Object.prototype.blep = 'blop';
     Object.getOwnPropertyNames(kEnumerableProperty),
     [ 'enumerable' ]
   );
+
+  assert.throws(
+    () => Object.setPrototypeOf(kEnumerableProperty, { value: undefined }),
+    TypeError
+  );
+  assert.throws(
+    () => delete kEnumerableProperty.enumerable,
+    TypeError
+  );
+  assert.throws(
+    () => kEnumerableProperty.enumerable = false,
+    TypeError
+  );
+  assert.throws(
+    () => Object.assign(kEnumerableProperty, { enumerable: false }),
+    TypeError
+  );
+  assert.throws(
+    () => kEnumerableProperty.value = undefined,
+    TypeError
+  );
+  assert.throws(
+    () => Object.assign(kEnumerableProperty, { value: undefined }),
+    TypeError
+  );
+  assert.throws(
+    () => Object.defineProperty(kEnumerableProperty, 'value', {}),
+    TypeError
+  );
 }
 
 {