Please sign in to comment.
test: refactor test-debugger-remote
1. The test doesn't attach an event listener for `exit` events and removes them before killing. The intention is to fail the tests if the processes exit normally. This patch attaches the `exit` event handlers. 2. Replace `var`s with `let`s and `const`s. 3. Replace `==` based assertion with `strictEqual` assertion. 4. Use `common.PORT` instead of `5959`. 5. The test used to expect only one string "connecting to localhost:5959 ... ok", but the debugger actually emits another string, "break in test/fixtures/empty.js:2". This patch asserts if both of them are received in the same order. Refer: #10361 PR-URL: #10455 Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Michaël Zasso <email@example.com>
- Loading branch information...
Showing with 31 additions and 21 deletions.