Skip to content

Commit 07d4372

Browse files
addaleaxBethGriggs
authored andcommitted
deps: V8: cherry-pick 94723c197199
Original commit message: api: Remove deprecated TracedReference::SetFinalizationCallback method TracedReference is supposed to be as light-weight as possible without destructor or other callbacks, essentially just representing a plain managed reference. Change-Id: Iae52cf7460e3623f1fb7d183757ecd39b2431369 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2033173 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#66106} Refs: v8/v8@94723c1 PR-URL: #32885 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
1 parent 4a11a54 commit 07d4372

File tree

2 files changed

+1
-28
lines changed

2 files changed

+1
-28
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# Reset this number to 0 on major V8 upgrades.
3737
# Increment by one for each non-official patch applied to deps/v8.
38-
'v8_embedder_string': '-node.15',
38+
'v8_embedder_string': '-node.16',
3939

4040
##### V8 defaults for Node.js #####
4141

deps/v8/include/v8.h

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1128,17 +1128,11 @@ class TracedReference : public TracedReferenceBase<T> {
11281128

11291129
/**
11301130
* Copy assignment operator initializing TracedGlobal from an existing one.
1131-
*
1132-
* Note: Prohibited when |other| has a finalization callback set through
1133-
* |SetFinalizationCallback|.
11341131
*/
11351132
V8_INLINE TracedReference& operator=(const TracedReference& rhs);
11361133

11371134
/**
11381135
* Copy assignment operator initializing TracedGlobal from an existing one.
1139-
*
1140-
* Note: Prohibited when |other| has a finalization callback set through
1141-
* |SetFinalizationCallback|.
11421136
*/
11431137
template <class S>
11441138
V8_INLINE TracedReference& operator=(const TracedReference<S>& rhs);
@@ -1155,20 +1149,6 @@ class TracedReference : public TracedReferenceBase<T> {
11551149
return reinterpret_cast<TracedReference<S>&>(
11561150
const_cast<TracedReference<T>&>(*this));
11571151
}
1158-
1159-
/**
1160-
* Adds a finalization callback to the handle. The type of this callback is
1161-
* similar to WeakCallbackType::kInternalFields, i.e., it will pass the
1162-
* parameter and the first two internal fields of the object.
1163-
*
1164-
* The callback is then supposed to reset the handle in the callback. No
1165-
* further V8 API may be called in this callback. In case additional work
1166-
* involving V8 needs to be done, a second callback can be scheduled using
1167-
* WeakCallbackInfo<void>::SetSecondPassCallback.
1168-
*/
1169-
V8_DEPRECATED("Use TracedGlobal<> if callbacks are required.")
1170-
V8_INLINE void SetFinalizationCallback(
1171-
void* parameter, WeakCallbackInfo<void>::Callback callback);
11721152
};
11731153

11741154
/**
@@ -10953,13 +10933,6 @@ void TracedGlobal<T>::SetFinalizationCallback(
1095310933
reinterpret_cast<internal::Address*>(this->val_), parameter, callback);
1095410934
}
1095510935

10956-
template <class T>
10957-
void TracedReference<T>::SetFinalizationCallback(
10958-
void* parameter, typename WeakCallbackInfo<void>::Callback callback) {
10959-
V8::SetFinalizationCallbackTraced(
10960-
reinterpret_cast<internal::Address*>(this->val_), parameter, callback);
10961-
}
10962-
1096310936
template <typename T>
1096410937
ReturnValue<T>::ReturnValue(internal::Address* slot) : value_(slot) {}
1096510938

0 commit comments

Comments
 (0)