Skip to content
Permalink
Browse files

n-api: remove idle_running from TsFn

The idle_running member variable in TsFn is always false and can
therefore be removed.

Backport-PR-URL: #25002
PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
  • Loading branch information...
ralphtheninja authored and rvagg committed Jul 27, 2018
1 parent 67b6e0d commit 09b88aabb3fd5cfd2da98ae83c2f1edd82d899c5
Showing with 6 additions and 12 deletions.
  1. +6 −12 src/node_api.cc
@@ -3614,7 +3614,6 @@ class TsFn: public node::AsyncResource {
env(env_),
finalize_data(finalize_data_),
finalize_cb(finalize_cb_),
idle_running(false),
call_js_cb(call_js_cb_ == nullptr ? CallJs : call_js_cb_),
handles_closing(false) {
ref.Reset(env->isolate, func);
@@ -3779,8 +3778,6 @@ class TsFn: public node::AsyncResource {
} else {
if (uv_idle_stop(&idle) != 0) {
idle_stop_failed = true;
} else {
idle_running = false;
}
}
}
@@ -3813,14 +3810,12 @@ class TsFn: public node::AsyncResource {
}

void MaybeStartIdle() {
if (!idle_running) {
if (uv_idle_start(&idle, IdleCb) != 0) {
v8::HandleScope scope(env->isolate);
CallbackScope cb_scope(this);
CHECK(napi_throw_error(env,
"ERR_NAPI_TSFN_START_IDLE_LOOP",
"Failed to start the idle loop") == napi_ok);
}
if (uv_idle_start(&idle, IdleCb) != 0) {
v8::HandleScope scope(env->isolate);
CallbackScope cb_scope(this);
CHECK(napi_throw_error(env,
"ERR_NAPI_TSFN_START_IDLE_LOOP",
"Failed to start the idle loop") == napi_ok);
}
}

@@ -3923,7 +3918,6 @@ class TsFn: public node::AsyncResource {
napi_env env;
void* finalize_data;
napi_finalize finalize_cb;
bool idle_running;
napi_threadsafe_function_call_js call_js_cb;
bool handles_closing;
};

0 comments on commit 09b88aa

Please sign in to comment.
You can’t perform that action at this time.