Skip to content

Commit

Permalink
crypto: make LazyTransform compabile with Streams1
Browse files Browse the repository at this point in the history
Makes LazyTransform writable by Streams1 by assigning .writable = true
before the actual classes are loaded.

Fixes: #12269
PR-URL: #12380
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
mcollina authored and MylesBorins committed May 18, 2017
1 parent dac66d5 commit 0a79b2d
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/internal/streams/lazy_transform.js
Expand Up @@ -10,6 +10,8 @@ module.exports = LazyTransform;

function LazyTransform(options) {
this._options = options;
this.writable = true;
this.readable = true;
}
util.inherits(LazyTransform, stream.Transform);

Expand Down
34 changes: 34 additions & 0 deletions test/parallel/test-crypto-lazy-transform-writable.js
@@ -0,0 +1,34 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const crypto = require('crypto');
const Stream = require('stream');
const util = require('util');

const hasher1 = crypto.createHash('sha256');
const hasher2 = crypto.createHash('sha256');

// Calculate the expected result.
hasher1.write(Buffer.from('hello world'));
hasher1.end();

const expected = hasher1.read().toString('hex');

function OldStream() {
Stream.call(this);

this.readable = true;
}
util.inherits(OldStream, Stream);

const stream = new OldStream();

stream.pipe(hasher2).on('finish', common.mustCall(function() {
const hash = hasher2.read().toString('hex');
assert.strictEqual(expected, hash);
}));

stream.emit('data', Buffer.from('hello'));
stream.emit('data', Buffer.from(' world'));
stream.emit('end');

0 comments on commit 0a79b2d

Please sign in to comment.