Skip to content

Commit 13637d2

Browse files
committed
tools: add falsely removed eslint rules
This adds the eslint rules back in that were falsely removed while landing #18566. PR-URL: #18933 Refs: #18566 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 95bae85 commit 13637d2

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

.eslintrc.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ module.exports = {
7171
'accessor-pairs': 'error',
7272
'array-callback-return': 'error',
7373
'dot-location': ['error', 'property'],
74+
'dot-notation': 'error',
7475
eqeqeq: ['error', 'smart'],
7576
'no-fallthrough': 'error',
7677
'no-global-assign': 'error',
@@ -111,6 +112,7 @@ module.exports = {
111112
],
112113
'no-return-await': 'error',
113114
'no-self-assign': 'error',
115+
'no-self-compare': 'error',
114116
'no-throw-literal': 'error',
115117
'no-unused-labels': 'error',
116118
'no-useless-call': 'error',
@@ -180,6 +182,10 @@ module.exports = {
180182
/* eslint-disable max-len, quotes */
181183
'no-restricted-syntax': [
182184
'error',
185+
{
186+
selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
187+
message: "Please replace `assert.doesNotThrow()` and add a comment next to the code instead."
188+
},
183189
{
184190
selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`,
185191
message: 'use a regular expression for second argument of assert.throws()',
@@ -204,6 +210,7 @@ module.exports = {
204210
/* eslint-enable max-len, quotes */
205211
'no-tabs': 'error',
206212
'no-trailing-spaces': 'error',
213+
'no-unsafe-finally': 'error',
207214
'object-curly-spacing': ['error', 'always'],
208215
'one-var-declaration-per-line': 'error',
209216
'operator-linebreak': ['error', 'after'],

0 commit comments

Comments
 (0)