Skip to content

Commit

Permalink
dns: remove Resolver#cancel() from promises API
Browse files Browse the repository at this point in the history
Because reasons.

PR-URL: #21264
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
cjihrig authored and targos committed Jun 20, 2018
1 parent aa864ba commit 18179f8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
8 changes: 0 additions & 8 deletions doc/api/dns.md
Original file line number Diff line number Diff line change
Expand Up @@ -622,14 +622,6 @@ The following methods from the `dnsPromises` API are available:
* [`resolver.resolveTxt()`][`dnsPromises.resolveTxt()`]
* [`resolver.reverse()`][`dnsPromises.reverse()`]

#### resolver.cancel()
<!-- YAML
added: REPLACEME
-->

Cancel all outstanding DNS queries made by this resolver. The corresponding
`Promise`s will be rejected with an error with code `ECANCELLED`.

### dnsPromises.getServers()
<!-- YAML
added: REPLACEME
Expand Down
1 change: 0 additions & 1 deletion lib/internal/dns/promises.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ class Resolver {
}
}

Resolver.prototype.cancel = CallbackResolver.prototype.cancel;
Resolver.prototype.getServers = CallbackResolver.prototype.getServers;
Resolver.prototype.setServers = CallbackResolver.prototype.setServers;
Resolver.prototype.resolveAny = resolveMap.ANY = resolver('queryAny');
Expand Down

0 comments on commit 18179f8

Please sign in to comment.