Skip to content

Commit 1b83a2b

Browse files
hkleungaimarco-ippolito
authored andcommitted
zlib: remove mentions of unexposed Z_TREES constant
`Z_TREES` is never exposed on `DefineZlibConstants()`, hence it shall be removed. This fix is applicable to v18+. Refs: https://github.com/nodejs/node/blob/main/src/node_zlib.cc PR-URL: #58371 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 9dc9604 commit 1b83a2b

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

doc/api/zlib.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,6 @@ Allowed flush values.
599599
* `zlib.constants.Z_FULL_FLUSH`
600600
* `zlib.constants.Z_FINISH`
601601
* `zlib.constants.Z_BLOCK`
602-
* `zlib.constants.Z_TREES`
603602

604603
Return codes for the compression/decompression functions. Negative
605604
values are errors, positive values are used for special but normal

lib/zlib.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ ZlibBase.prototype._final = function(callback) {
315315
// This is currently only used to figure out which flush flag to use for the
316316
// last chunk.
317317
// Roughly, the following holds:
318-
// Z_NO_FLUSH (< Z_TREES) < Z_BLOCK < Z_PARTIAL_FLUSH <
318+
// Z_NO_FLUSH < Z_BLOCK < Z_PARTIAL_FLUSH <
319319
// Z_SYNC_FLUSH < Z_FULL_FLUSH < Z_FINISH
320320
const flushiness = [];
321321
const kFlushFlagList = [Z_NO_FLUSH, Z_BLOCK, Z_PARTIAL_FLUSH,

0 commit comments

Comments
 (0)