Skip to content

Commit 1ce9416

Browse files
addaleaxtargos
authored andcommitted
test: fix flaky addons/callback-scope/test-resolve-async
Fixes: #22668 PR-URL: #22664 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 2b49b43 commit 1ce9416

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/addons/callback-scope/test-resolve-async.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ const common = require('../../common');
44
const assert = require('assert');
55
const { testResolveAsync } = require(`./build/${common.buildType}/binding`);
66

7+
// Checks that resolving promises from C++ works.
8+
79
let called = false;
810
testResolveAsync().then(() => { called = true; });
911

10-
setTimeout(() => { assert(called); }, common.platformTimeout(50));
12+
process.on('beforeExit', () => { assert(called); });

0 commit comments

Comments
 (0)