Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
test: only assert on first lines of TLS trace
The TLS trace data is best-effort, and enough can be dropped from pipe
buffers that only the start of the trace is detected. Only assert on the
first line of the trace, it should not get dropped, and it's enough to
check that trace was enabled via CLI.

PR-URL: #28043
Fixes: #27636
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
sam-github authored and BridgeAR committed Jun 17, 2019
1 parent 9dd4813 commit 1ef2811
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions test/parallel/parallel.status
Expand Up @@ -9,8 +9,6 @@ prefix parallel
test-net-connect-options-port: PASS,FLAKY
# https://github.com/nodejs/node/issues/26401
test-worker-prof: PASS,FLAKY
# https://github.com/nodejs/node/issues/27553
test-tls-enable-trace-cli: PASS,FLAKY

[$system==win32]
test-http2-pipe: PASS,FLAKY
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-tls-enable-trace-cli.js
Expand Up @@ -37,7 +37,6 @@ child.on('close', common.mustCall((code, signal) => {
assert.strictEqual(stdout.trim(), '');
assert(/Warning: Enabling --trace-tls can expose sensitive/.test(stderr));
assert(/Sent Record/.test(stderr));
assert(/Received Record/.test(stderr));
}));

function test() {
Expand Down

0 comments on commit 1ef2811

Please sign in to comment.