Skip to content

Commit

Permalink
deps: patch V8 to 6.4.388.41
Browse files Browse the repository at this point in the history
PR-URL: #18522
Refs: v8/v8@6.4.388.40...6.4.388.41
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
MylesBorins committed Feb 5, 2018
1 parent a52b7a2 commit 1f76482
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 1 deletion.
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 6
#define V8_MINOR_VERSION 4
#define V8_BUILD_NUMBER 388
#define V8_PATCH_LEVEL 40
#define V8_PATCH_LEVEL 41

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
1 change: 1 addition & 0 deletions deps/v8/src/factory.cc
Expand Up @@ -1613,6 +1613,7 @@ Handle<JSFunction> Factory::NewFunction(const NewFunctionArgs& args) {
}
Handle<Map> initial_map = NewMap(args.type_, args.instance_size_,
elements_kind, args.inobject_properties_);
result->shared()->set_expected_nof_properties(args.inobject_properties_);
// TODO(littledan): Why do we have this is_generator test when
// NewFunctionPrototype already handles finding an appropriately
// shared prototype?
Expand Down
22 changes: 22 additions & 0 deletions deps/v8/test/mjsunit/regress/regress-crbug-800032.js
@@ -0,0 +1,22 @@
// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Flags: --allow-natives-syntax --expose-gc


class Derived extends RegExp {
constructor(a) {
// Syntax Error
const a = 1;
}
}

let o = Reflect.construct(RegExp, [], Derived);
%HeapObjectVerify(o);
// Check that we can properly access lastIndex.
assertEquals(o.lastIndex, 0);
o.lastIndex = 1;
assertEquals(o.lastIndex, 1);
o.lastIndex = 0;
gc();

0 comments on commit 1f76482

Please sign in to comment.