Skip to content
Browse files

benchmark: support optional headers with wrk

wrk did not support sending optional headers, they were silently
ignored. This appears to be an oversight, they were supported for

PR-URL: nodejs-private/node-private#189
Reviewed-By: Matteo Collina <>
Reviewed-By: Fedor Indutny <>
Reviewed-By: Ben Noordhuis <>
Reviewed-By: James M Snell <>
  • Loading branch information
sam-github authored and BethGriggs committed Jan 14, 2020
1 parent d617fdf commit 209767c7a2154167183a59b88270abfecbd67662
Showing with 3 additions and 0 deletions.
  1. +3 −0 benchmark/_http-benchmarkers.js
@@ -64,6 +64,9 @@ class WrkBenchmarker {
'-t', 8,
for (const field in options.headers) {
args.push('-H', `${field}: ${options.headers[field]}`);
const child = child_process.spawn(this.executable, args);
return child;

0 comments on commit 209767c

Please sign in to comment.
You can’t perform that action at this time.