dns: make promise API fully constructed from lib/internal/dns/promises

PR-URL: #43227 Refs: #43198 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
nodejs · Jul 12, 2022 · 2149acd · 2149acd
1 parent 9bd13bb
commit 2149acd
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/lib/dns.js b/lib/dns.js
@@ -439,8 +439,6 @@ ObjectDefineProperties(module.exports, {
     get() {
       if (promises === null) {
         promises = require('internal/dns/promises');
-        promises.setServers = defaultResolverSetServers;
-        promises.setDefaultResultOrder = setDefaultResultOrder;
       }
       return promises;
     }

diff --git a/lib/dns/promises.js b/lib/dns/promises.js
@@ -1,5 +1,3 @@
 'use strict';
 
-const dnsPromises = require('internal/dns/promises');
-dnsPromises.setServers = require('dns').setServers;
-module.exports = dnsPromises;
+module.exports = require('internal/dns/promises');
diff --git a/lib/internal/dns/promises.js b/lib/internal/dns/promises.js
@@ -17,6 +17,8 @@ const {
   emitInvalidHostnameWarning,
   getDefaultVerbatim,
   errorCodes: dnsErrorCodes,
+  setDefaultResultOrder,
+  setDefaultResolver,
 } = require('internal/dns/utils');
 const {
   NODATA,
@@ -349,11 +351,20 @@ Resolver.prototype.resolve = function resolve(hostname, rrtype) {
   return ReflectApply(resolver, this, [hostname]);
 };
 
+function defaultResolverSetServers(servers) {
+  const resolver = new Resolver();
+
+  resolver.setServers(servers);
+  setDefaultResolver(resolver);
+  bindDefaultResolver(module.exports, Resolver.prototype);
+}
 
 module.exports = {
   lookup,
   lookupService,
   Resolver,
+  setDefaultResultOrder,
+  setServers: defaultResolverSetServers,
 
   // ERROR CODES
   NODATA,