Skip to content
Permalink
Browse files

lib: simplify several debug() calls

Avoid calling Array.prototype.join() in debug() calls. These
are evaluated on every call, even if the debug() call is a
no-op. This commit replaces the join() calls with the %j
placeholder.

PR-URL: #25241
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
cjihrig authored and targos committed Dec 27, 2018
1 parent e6b5232 commit 217bb0e5f08f7d09fdd3861a0a69d2e7fa5d27d5
Showing with 3 additions and 5 deletions.
  1. +2 −2 lib/internal/http2/core.js
  2. +1 −3 lib/internal/modules/esm/create_dynamic_module.js
@@ -477,8 +477,8 @@ function onOrigin(origins) {
const session = this[kOwner];
if (session.destroyed)
return;
debug(`Http2Session ${sessionName(session[kType])}: origin received: ` +
`${origins.join(', ')}`);
debug('Http2Session %s: origin received: %j',
sessionName(session[kType]), origins);
session[kUpdateTimer]();
if (!session.encrypted || session.destroyed)
return undefined;
@@ -6,9 +6,7 @@ const ArrayJoin = Function.call.bind(Array.prototype.join);
const ArrayMap = Function.call.bind(Array.prototype.map);

const createDynamicModule = (exports, url = '', evaluate) => {
debug(
`creating ESM facade for ${url} with exports: ${ArrayJoin(exports, ', ')}`
);
debug('creating ESM facade for %s with exports: %j', url, exports);
const names = ArrayMap(exports, (name) => `${name}`);

const source = `

0 comments on commit 217bb0e

Please sign in to comment.
You can’t perform that action at this time.