Skip to content

Commit 275c070

Browse files
Renegade334targos
authored andcommitted
typings: update 'types' binding
- Adds: - isGeneratorObject - isProxy - isSharedArrayBuffer - isSymbolObject - Removes: - isTypedArray - Fixes: - isDate - isNativeError - isRegExp - Improves: - isArgumentsObject - isExternal PR-URL: #59692 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent d728545 commit 275c070

File tree

2 files changed

+33
-30
lines changed

2 files changed

+33
-30
lines changed

src/node_types.cc

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,31 +14,31 @@ namespace node {
1414
namespace {
1515

1616
#define VALUE_METHOD_MAP(V) \
17-
V(External) \
18-
V(Date) \
1917
V(ArgumentsObject) \
18+
V(ArrayBuffer) \
19+
V(AsyncFunction) \
2020
V(BigIntObject) \
2121
V(BooleanObject) \
22-
V(NumberObject) \
23-
V(StringObject) \
24-
V(SymbolObject) \
25-
V(NativeError) \
26-
V(RegExp) \
27-
V(AsyncFunction) \
22+
V(DataView) \
23+
V(Date) \
24+
V(External) \
2825
V(GeneratorFunction) \
2926
V(GeneratorObject) \
30-
V(Promise) \
3127
V(Map) \
32-
V(Set) \
3328
V(MapIterator) \
29+
V(ModuleNamespaceObject) \
30+
V(NativeError) \
31+
V(NumberObject) \
32+
V(Promise) \
33+
V(Proxy) \
34+
V(RegExp) \
35+
V(Set) \
3436
V(SetIterator) \
35-
V(WeakMap) \
36-
V(WeakSet) \
37-
V(ArrayBuffer) \
38-
V(DataView) \
3937
V(SharedArrayBuffer) \
40-
V(Proxy) \
41-
V(ModuleNamespaceObject)
38+
V(StringObject) \
39+
V(SymbolObject) \
40+
V(WeakMap) \
41+
V(WeakSet)
4242

4343
#define V(type) \
4444
static void Is##type(const FunctionCallbackInfo<Value>& args) { \

typings/internalBinding/types.d.ts

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,29 @@
11
export interface TypesBinding {
2-
isAsyncFunction(value: unknown): value is (...args: unknown[]) => Promise<unknown>;
3-
isGeneratorFunction(value: unknown): value is GeneratorFunction;
4-
isAnyArrayBuffer(value: unknown): value is (ArrayBuffer | SharedArrayBuffer);
2+
isArgumentsObject(value: unknown): value is IArguments;
53
isArrayBuffer(value: unknown): value is ArrayBuffer;
6-
isArgumentsObject(value: unknown): value is ArrayLike<unknown>;
7-
isBoxedPrimitive(value: unknown): value is (BigInt | Boolean | Number | String | Symbol);
4+
isAsyncFunction(value: unknown): value is (...args: unknown[]) => Promise<unknown>;
5+
isBigIntObject: (value: unknown) => value is BigInt;
6+
isBooleanObject: (value: unknown) => value is Boolean;
87
isDataView(value: unknown): value is DataView;
9-
isExternal(value: unknown): value is Object;
8+
isDate: (value: unknown) => value is Date;
9+
isExternal(value: unknown): value is object;
10+
isGeneratorFunction(value: unknown): value is GeneratorFunction;
11+
isGeneratorObject(value: unknown): value is Generator;
1012
isMap(value: unknown): value is Map<unknown, unknown>;
1113
isMapIterator: (value: unknown) => value is IterableIterator<unknown>;
1214
isModuleNamespaceObject: (value: unknown) => value is { [Symbol.toStringTag]: 'Module' };
13-
isNativeError: (value: unknown) => Error;
15+
isNativeError: (value: unknown) => value is Error;
16+
isNumberObject: (value: unknown) => value is Number;
1417
isPromise: (value: unknown) => value is Promise<unknown>;
18+
isProxy: (value: unknown) => value is object;
19+
isRegExp: (value: unknown) => value is RegExp;
1520
isSet: (value: unknown) => value is Set<unknown>;
1621
isSetIterator: (value: unknown) => value is IterableIterator<unknown>;
22+
isSharedArrayBuffer: (value: unknown) => value is SharedArrayBuffer;
23+
isStringObject: (value: unknown) => value is String;
24+
isSymbolObject: (value: unknown) => value is Symbol;
1725
isWeakMap: (value: unknown) => value is WeakMap<object, unknown>;
1826
isWeakSet: (value: unknown) => value is WeakSet<object>;
19-
isRegExp: (value: unknown) => RegExp;
20-
isDate: (value: unknown) => Date;
21-
isTypedArray: (value: unknown) => value is TypedArray;
22-
isStringObject: (value: unknown) => value is String;
23-
isNumberObject: (value: unknown) => value is Number;
24-
isBooleanObject: (value: unknown) => value is Boolean,
25-
isBigIntObject: (value: unknown) => value is BigInt;
27+
isAnyArrayBuffer(value: unknown): value is ArrayBufferLike;
28+
isBoxedPrimitive(value: unknown): value is BigInt | Boolean | Number | String | Symbol;
2629
}

0 commit comments

Comments
 (0)