Skip to content
Permalink
Browse files

src: simplify uptime and ppid return values

This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

PR-URL: #24562
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
  • Loading branch information...
cjihrig authored and BethGriggs committed Nov 22, 2018
1 parent ccefef2 commit 28a1cc1377b4f762613d58161a601d03bf807dd3
Showing with 2 additions and 3 deletions.
  1. +2 −3 src/node_process.cc
@@ -54,7 +54,6 @@ using v8::Integer;
using v8::Isolate;
using v8::Local;
using v8::Name;
using v8::Number;
using v8::PropertyCallbackInfo;
using v8::String;
using v8::Uint32;
@@ -268,7 +267,7 @@ void Uptime(const FunctionCallbackInfo<Value>& args) {
uv_update_time(env->event_loop());
uptime = uv_now(env->event_loop()) - prog_start_time;

args.GetReturnValue().Set(Number::New(env->isolate(), uptime / 1000));
args.GetReturnValue().Set(uptime / 1000);
}


@@ -793,7 +792,7 @@ void EnvEnumerator(const PropertyCallbackInfo<Array>& info) {

void GetParentProcessId(Local<Name> property,
const PropertyCallbackInfo<Value>& info) {
info.GetReturnValue().Set(Integer::New(info.GetIsolate(), uv_os_getppid()));
info.GetReturnValue().Set(uv_os_getppid());
}

void GetActiveRequests(const FunctionCallbackInfo<Value>& args) {

0 comments on commit 28a1cc1

Please sign in to comment.
You can’t perform that action at this time.