Skip to content
Permalink
Browse files

test: fixing AliasedBuffer tests to enter Isolate

AliasedBuffer tests weren't creating an v8::Isolate::Scope, and this
had negative impact on the node-chakracore branch, where expectation
is an Isoalte has been Enter()'d before being used.

PR-URL: #15536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
mike-kaufman authored and jasnell committed Sep 21, 2017
1 parent 4f88c19 commit 29f0ad6ccb4a4a52d445ce4421448b3fc9e0cd8a
Showing with 2 additions and 0 deletions.
  1. +2 −0 test/cctest/test_aliased_buffer.cc
@@ -82,6 +82,7 @@ void ReadAndValidate(v8::Isolate* isolate,

template<class NativeT, class V8T>
void ReadWriteTest(v8::Isolate* isolate) {
v8::Isolate::Scope isolate_scope(isolate);
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = v8::Context::New(isolate);
v8::Context::Scope context_scope(context);
@@ -114,6 +115,7 @@ void SharedBufferTest(
size_t count_A,
size_t count_B,
size_t count_C) {
v8::Isolate::Scope isolate_scope(isolate);
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = v8::Context::New(isolate);
v8::Context::Scope context_scope(context);

0 comments on commit 29f0ad6

Please sign in to comment.
You can’t perform that action at this time.