Skip to content

Commit 29f0ad6

Browse files
Mike Kaufmanjasnell
authored andcommitted
test: fixing AliasedBuffer tests to enter Isolate
AliasedBuffer tests weren't creating an v8::Isolate::Scope, and this had negative impact on the node-chakracore branch, where expectation is an Isoalte has been Enter()'d before being used. PR-URL: #15536 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 4f88c19 commit 29f0ad6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/cctest/test_aliased_buffer.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ void ReadAndValidate(v8::Isolate* isolate,
8282

8383
template<class NativeT, class V8T>
8484
void ReadWriteTest(v8::Isolate* isolate) {
85+
v8::Isolate::Scope isolate_scope(isolate);
8586
v8::HandleScope handle_scope(isolate);
8687
v8::Local<v8::Context> context = v8::Context::New(isolate);
8788
v8::Context::Scope context_scope(context);
@@ -114,6 +115,7 @@ void SharedBufferTest(
114115
size_t count_A,
115116
size_t count_B,
116117
size_t count_C) {
118+
v8::Isolate::Scope isolate_scope(isolate);
117119
v8::HandleScope handle_scope(isolate);
118120
v8::Local<v8::Context> context = v8::Context::New(isolate);
119121
v8::Context::Scope context_scope(context);

0 commit comments

Comments
 (0)