Skip to content

Commit 30c2c0f

Browse files
addaleaxtargos
authored andcommitted
src: remove unnecessary shadowed functions on Utf8Value & BufferValue
Both of these are already implemented on the superclass. PR-URL: #60056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent eb99eec commit 30c2c0f

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/util.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -553,11 +553,6 @@ class Utf8Value : public MaybeStackBuffer<char> {
553553
public:
554554
explicit Utf8Value(v8::Isolate* isolate, v8::Local<v8::Value> value);
555555

556-
inline std::string ToString() const { return std::string(out(), length()); }
557-
inline std::string_view ToStringView() const {
558-
return std::string_view(out(), length());
559-
}
560-
561556
inline bool operator==(const char* a) const { return strcmp(out(), a) == 0; }
562557
inline bool operator!=(const char* a) const { return !(*this == a); }
563558
};
@@ -571,10 +566,6 @@ class BufferValue : public MaybeStackBuffer<char> {
571566
public:
572567
explicit BufferValue(v8::Isolate* isolate, v8::Local<v8::Value> value);
573568

574-
inline std::string ToString() const { return std::string(out(), length()); }
575-
inline std::string_view ToStringView() const {
576-
return std::string_view(out(), length());
577-
}
578569
inline std::u8string_view ToU8StringView() const {
579570
return std::u8string_view(reinterpret_cast<const char8_t*>(out()),
580571
length());

0 commit comments

Comments
 (0)