Skip to content
Permalink
Browse files

src: cleanup unused headers

Node codebase has evolved a lot in the more than 10 years of its
existence. As more features (and code) have been added, changed,
removed, it's sometimes hard to keep track of what gets used and what
not.

This commits attempts to clean some of those potentially left-over
headers using suggestions from  include-what-you-use

Refs: #27531

PR-URL: #30328
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
alferpal authored and MylesBorins committed Nov 7, 2019
1 parent f6360c1 commit 3bb085dbad4d23030c731834e35b2804c8a50b23
@@ -1,5 +1,4 @@
#include "node.h"
#include "env-inl.h"
#include "string_bytes.h"
#include "util-inl.h"
#include "v8.h"
@@ -1,6 +1,4 @@
#include "node.h"
#include "node_internals.h"
#include "util-inl.h"

#include <csignal>

@@ -27,7 +27,6 @@
#include "util-inl.h"

#include "v8.h"
#include "v8-profiler.h"

using v8::Context;
using v8::DontDelete;
@@ -1,14 +1,12 @@
#include "connect_wrap.h"

#include "env-inl.h"
#include "req_wrap-inl.h"
#include "util-inl.h"

namespace node {

using v8::Local;
using v8::Object;

class Environment;

ConnectWrap::ConnectWrap(Environment* env,
Local<Object> req_wrap_obj,
@@ -3,10 +3,8 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "env.h"
#include "req_wrap-inl.h"
#include "async_wrap.h"
#include "v8.h"

namespace node {

@@ -4,7 +4,6 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "stream_wrap.h"
#include "v8.h"

namespace node {

@@ -1,6 +1,5 @@
#include "debug_utils.h"
#include "env-inl.h"
#include "util-inl.h"

#ifdef __POSIX__
#if defined(__linux__)
@@ -7,7 +7,6 @@
#include "node_errors.h"
#include "node_file.h"
#include "node_internals.h"
#include "node_native_module.h"
#include "node_options-inl.h"
#include "node_process.h"
#include "node_v8_platform-inl.h"
@@ -21,7 +21,6 @@

#include "async_wrap-inl.h"
#include "env-inl.h"
#include "util-inl.h"
#include "node.h"
#include "handle_wrap.h"
#include "string_bytes.h"
@@ -23,7 +23,6 @@
#include "async_wrap-inl.h"
#include "env-inl.h"
#include "util-inl.h"
#include "node.h"

namespace node {

@@ -2,7 +2,6 @@

#include "async_wrap.h"
#include "env-inl.h"
#include "node_buffer.h"
#include "node_errors.h"
#include "stream_base-inl.h"
#include "util-inl.h"
@@ -5,7 +5,6 @@

#include "async_wrap.h"
#include "stream_base.h"
#include "v8.h"

namespace node {

@@ -6,10 +6,12 @@
#include <unordered_map>
#include <string>
#include <vector>
#include "node_url.h"
#include "base_object-inl.h"
#include "base_object.h"

namespace node {

class Environment;

namespace loader {

enum ScriptType : int {
@@ -10,9 +10,6 @@
#include "node.h"
#define NAPI_EXPERIMENTAL
#include "node_api.h"
#include "util.h"
#include "uv.h"
#include "v8.h"

enum {
NM_F_BUILTIN = 1 << 0, // Unused.
@@ -28,7 +28,6 @@
#include "string_bytes.h"
#include "string_search.h"
#include "util-inl.h"
#include "v8-profiler.h"
#include "v8.h"

#include <cstring>
@@ -3,8 +3,6 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "node.h"
#include "util.h"
#include "env.h"
#include "v8.h"

@@ -24,7 +24,6 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "v8.h"
#include "uv.h"
#include "node_mutex.h"
#include <vector>
@@ -26,7 +26,6 @@

#include "stream_base.h"
#include "handle_wrap.h"
#include "string_bytes.h"
#include "v8.h"

namespace node {
@@ -27,7 +27,7 @@
// Decodes a v8::Local<v8::String> or Buffer to a raw char*

#include "v8.h"
#include "env.h"
#include "env-inl.h"

namespace node {

@@ -4,7 +4,6 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "string_decoder.h"
#include "util.h"

namespace node {

@@ -3,7 +3,6 @@

#include "libplatform/v8-tracing.h"
#include "uv.h"
#include "v8.h"
#include "util.h"
#include "node_mutex.h"

@@ -12,6 +11,11 @@
#include <string>
#include <unordered_map>

namespace v8 {
class ConvertableToTraceFormat;
class TracingController;
} // namespace v8

namespace node {
namespace tracing {

@@ -24,7 +24,6 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "async_wrap.h"
#include "handle_wrap.h"
#include "uv.h"
#include "v8.h"

0 comments on commit 3bb085d

Please sign in to comment.
You can’t perform that action at this time.