Skip to content
Permalink
Browse files

test: fix failing assertion

One test did not cause an assertion. By changing the test to use
`assert.throws()` all tests have to throw, otherwise the test will
fail.

PR-URL: #25250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
BridgeAR authored and addaleax committed Dec 28, 2018
1 parent e09dd0c commit 3bebcf01805b7dbfc30ec9f77e314b555d241c5e
Showing with 9 additions and 11 deletions.
  1. +9 −11 test/parallel/test-assert.js
@@ -257,16 +257,14 @@ const circular = { y: 1 };
circular.x = circular;

function testAssertionMessage(actual, expected, msg) {
try {
assert.strictEqual(actual, '');
} catch (e) {
assert.strictEqual(
e.message,
msg || strictEqualMessageStart +
`+ actual - expected\n\n+ ${expected}\n- ''`
);
assert.ok(e.generatedMessage, 'Message not marked as generated');
}
assert.throws(
() => assert.strictEqual(actual, ''),
{
generatedMessage: true,
message: msg || strictEqualMessageStart +
`+ actual - expected\n\n+ ${expected}\n- ''`
}
);
}

function testShortAssertionMessage(actual, expected) {
@@ -280,7 +278,7 @@ testShortAssertionMessage(false, 'false');
testShortAssertionMessage(100, '100');
testShortAssertionMessage(NaN, 'NaN');
testShortAssertionMessage(Infinity, 'Infinity');
testShortAssertionMessage('', '""');
testShortAssertionMessage('a', '"a"');
testShortAssertionMessage('foo', '\'foo\'');
testShortAssertionMessage(0, '0');
testShortAssertionMessage(Symbol(), 'Symbol()');

0 comments on commit 3bebcf0

Please sign in to comment.
You can’t perform that action at this time.