Skip to content

Commit

Permalink
src: update NODE_MODULE_VERSION to 111
Browse files Browse the repository at this point in the history
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 10.7.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: #44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
targos committed Oct 11, 2022
1 parent 06aaf8a commit 3efe901
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions doc/abi_version_registry.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"NODE_MODULE_VERSION": [
{ "modules": 111,"runtime": "node", "variant": "v8_10.7", "versions": "19.0.0-pre" },
{ "modules": 110,"runtime": "electron", "variant": "electron", "versions": "22" },
{ "modules": 109,"runtime": "electron", "variant": "electron", "versions": "21" },
{ "modules": 108,"runtime": "node", "variant": "v8_10.1", "versions": "18.0.0" },
Expand Down
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
* version matching should open a pull request to reserve a number in this
* registry.
*/
#define NODE_MODULE_VERSION 108
#define NODE_MODULE_VERSION 111

// The NAPI_VERSION provided by this version of the runtime. This is the version
// which the Node binary being built supports.
Expand Down

0 comments on commit 3efe901

Please sign in to comment.