Skip to content


Browse files Browse the repository at this point in the history
doc: mention where to push security commits
PR-URL: #44691
Reviewed-By: Danielle Adams <>
Reviewed-By: Michaël Zasso <>
Reviewed-By: Myles Borins <>
  • Loading branch information
RafaelGSS committed Sep 26, 2022
1 parent 82cb815 commit 4dbe4a0
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions doc/contributing/
Expand Up @@ -263,6 +263,19 @@ branch.
$ git checkout -b v1.2.3-proposal upstream/v1.x-staging

<summary>Security release</summary>

When performing Security Releases, the `vN.x.x-proposal` branch should be
branched off of `vN.x`.

$ git checkout -b v1.2.3-proposal upstream/v1.x
git cherry-pick ... # cherry-pick nodejs-private PR commits directly into the proposal


### 3. Update `src/node_version.h`

Set the version for the proposed release using the following macros, which are
Expand Down Expand Up @@ -458,6 +471,9 @@ Notable changes:

**Note**: Ensure to push the proposal branch to the nodejs-private repository.
Otherwise, you will leak the commits before the security release.


### 6. Propose release on GitHub
Expand Down

0 comments on commit 4dbe4a0

Please sign in to comment.