Skip to content

Commit 4e3731c

Browse files
cjihrigevanlucas
authored andcommitted
child_process: remove unreachable code
_convertCustomFds() is only called from normalizeSpawnArguments(), which always provides an options object. Therefore, there is no need to check for options in _convertCustomFds(). PR-URL: #9307 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1037463 commit 4e3731c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/child_process.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ var _deprecatedCustomFds = internalUtil.deprecate(function(options) {
305305
'Use options.stdio instead.');
306306

307307
function _convertCustomFds(options) {
308-
if (options && options.customFds && !options.stdio) {
308+
if (options.customFds && !options.stdio) {
309309
_deprecatedCustomFds(options);
310310
}
311311
}

0 commit comments

Comments
 (0)