Skip to content

Commit 5459f4a

Browse files
sokratargos
authored andcommitted
http: clean up HttpParser correctly
Remove reference to kOnMessageBegin from HttpParser to avoid leaking Server instances in FreeList. PR-URL: #39292 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent f70fd00 commit 5459f4a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lib/_http_common.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
4545

4646
const kIncomingMessage = Symbol('IncomingMessage');
4747
const kRequestTimeout = Symbol('RequestTimeout');
48+
const kOnMessageBegin = HTTPParser.kOnMessageBegin | 0;
4849
const kOnHeaders = HTTPParser.kOnHeaders | 0;
4950
const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
5051
const kOnBody = HTTPParser.kOnBody | 0;
@@ -238,6 +239,7 @@ function cleanParser(parser) {
238239
parser.incoming = null;
239240
parser.outgoing = null;
240241
parser.maxHeaderPairs = MAX_HEADER_PAIRS;
242+
parser[kOnMessageBegin] = null;
241243
parser[kOnExecute] = null;
242244
parser[kOnTimeout] = null;
243245
parser._consumed = false;

0 commit comments

Comments
 (0)