Skip to content

Commit 552cee0

Browse files
addaleaxBethGriggs
authored andcommitted
deps: V8: cherry-pick 700b1b97e9ab
Original commit message: [api] Remove deprecated wasm module type check The method was deprecated in favor of {IsWasmModuleObject}. R=adamk@chromium.org Bug: v8:10155 Change-Id: Id21a1b74dde5576c2c82cc209555c22209a9e5d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2033170 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66469} Refs: v8/v8@700b1b9 PR-URL: #32885 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
1 parent 9b7a1b0 commit 552cee0

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# Reset this number to 0 on major V8 upgrades.
3737
# Increment by one for each non-official patch applied to deps/v8.
38-
'v8_embedder_string': '-node.23',
38+
'v8_embedder_string': '-node.24',
3939

4040
##### V8 defaults for Node.js #####
4141

deps/v8/include/v8.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2786,9 +2786,6 @@ class V8_EXPORT Value : public Data {
27862786
*/
27872787
bool IsWasmModuleObject() const;
27882788

2789-
V8_DEPRECATED("Use IsWasmModuleObject")
2790-
bool IsWebAssemblyCompiledModule() const;
2791-
27922789
/**
27932790
* Returns true if the value is a Module Namespace Object.
27942791
*/

deps/v8/src/api/api.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3438,7 +3438,6 @@ VALUE_IS_SPECIFIC_TYPE(Set, JSSet)
34383438
VALUE_IS_SPECIFIC_TYPE(WasmModuleObject, WasmModuleObject)
34393439
VALUE_IS_SPECIFIC_TYPE(WeakMap, JSWeakMap)
34403440
VALUE_IS_SPECIFIC_TYPE(WeakSet, JSWeakSet)
3441-
VALUE_IS_SPECIFIC_TYPE(WebAssemblyCompiledModule, WasmModuleObject)
34423441

34433442
#undef VALUE_IS_SPECIFIC_TYPE
34443443

0 commit comments

Comments
 (0)