Skip to content

Commit 56989d3

Browse files
authored
src: remove deprecated node::EmitBeforeExit and node::EmitExit
PR-URL: #58469 Refs: #35486 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 41ab185 commit 56989d3

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

src/api/hooks.cc

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ void AtExit(Environment* env, void (*cb)(void* arg), void* arg) {
2626
env->AtExit(cb, arg);
2727
}
2828

29-
void EmitBeforeExit(Environment* env) {
30-
USE(EmitProcessBeforeExit(env));
31-
}
32-
3329
Maybe<bool> EmitProcessBeforeExit(Environment* env) {
3430
TRACE_EVENT0(TRACING_CATEGORY_NODE1(environment), "BeforeExit");
3531
if (!env->destroy_async_id_list()->empty())
@@ -50,14 +46,6 @@ Maybe<bool> EmitProcessBeforeExit(Environment* env) {
5046
: Just(true);
5147
}
5248

53-
static ExitCode EmitExitInternal(Environment* env) {
54-
return EmitProcessExitInternal(env).FromMaybe(ExitCode::kGenericUserError);
55-
}
56-
57-
int EmitExit(Environment* env) {
58-
return static_cast<int>(EmitExitInternal(env));
59-
}
60-
6149
Maybe<ExitCode> EmitProcessExitInternal(Environment* env) {
6250
// process.emit('exit')
6351
Isolate* isolate = env->isolate();

src/node.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -844,13 +844,9 @@ NODE_EXTERN void SetTracingController(v8::TracingController* controller);
844844
// Run `process.emit('beforeExit')` as it would usually happen when Node.js is
845845
// run in standalone mode.
846846
NODE_EXTERN v8::Maybe<bool> EmitProcessBeforeExit(Environment* env);
847-
NODE_DEPRECATED("Use Maybe version (EmitProcessBeforeExit) instead",
848-
NODE_EXTERN void EmitBeforeExit(Environment* env));
849847
// Run `process.emit('exit')` as it would usually happen when Node.js is run
850848
// in standalone mode. The return value corresponds to the exit code.
851849
NODE_EXTERN v8::Maybe<int> EmitProcessExit(Environment* env);
852-
NODE_DEPRECATED("Use Maybe version (EmitProcessExit) instead",
853-
NODE_EXTERN int EmitExit(Environment* env));
854850

855851
// Runs hooks added through `AtExit()`. This is part of `FreeEnvironment()`,
856852
// so calling it manually is typically not necessary.

0 commit comments

Comments
 (0)