Skip to content
Permalink
Browse files

tools: fix GYP MSVS solution generator for Python 3

PR-URL: #29897
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
  • Loading branch information
targos committed Oct 9, 2019
1 parent 8da83e8 commit 59033f618aa608a39c7a496edf449e5a2ba65fd4
Showing with 3 additions and 2 deletions.
  1. +3 −2 tools/gyp/pylib/gyp/MSVSNew.py
@@ -7,6 +7,7 @@
import hashlib
import os
import random
from operator import attrgetter

import gyp.common

@@ -86,7 +87,7 @@ def __init__(self, path, name = None, entries = None,
self.guid = guid

# Copy passed lists (or set to empty lists)
self.entries = sorted(list(entries or []))
self.entries = sorted(entries or [], key=attrgetter('path'))
self.items = list(items or [])

self.entry_type_guid = ENTRY_TYPE_GUIDS['folder']
@@ -230,7 +231,7 @@ def Write(self, writer=gyp.common.WriteOnDiff):
if isinstance(e, MSVSFolder):
entries_to_check += e.entries

all_entries = sorted(all_entries)
all_entries = sorted(all_entries, key=attrgetter('path'))

# Open file and print header
f = writer(self.path)

0 comments on commit 59033f6

Please sign in to comment.
You can’t perform that action at this time.