Skip to content

Commit 59eeb3b

Browse files
backesmmarchini
authored andcommitted
src: stop overriding deprecated V8 methods
These methods will be removed in V8 8.1, hence we need to stop overriding them. PR-URL: #32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 1cd235d commit 59eeb3b

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/node_platform.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -149,14 +149,6 @@ class NodePlatform : public MultiIsolatePlatform {
149149
void CallOnWorkerThread(std::unique_ptr<v8::Task> task) override;
150150
void CallDelayedOnWorkerThread(std::unique_ptr<v8::Task> task,
151151
double delay_in_seconds) override;
152-
void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override {
153-
UNREACHABLE();
154-
}
155-
void CallDelayedOnForegroundThread(v8::Isolate* isolate,
156-
v8::Task* task,
157-
double delay_in_seconds) override {
158-
UNREACHABLE();
159-
}
160152
bool IdleTasksEnabled(v8::Isolate* isolate) override;
161153
double MonotonicallyIncreasingTime() override;
162154
double CurrentClockTimeMillis() override;

0 commit comments

Comments
 (0)