Skip to content
Permalink
Browse files

test: remove unused --expose-native-as V8 flag

test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: #25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
  • Loading branch information...
peterwmwong authored and addaleax committed Dec 29, 2018
1 parent 61fc3bf commit 5a5bc58b4ff8ed8053a2cf81d6b553af38d3c0a9
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/parallel/test-preload.js
@@ -155,7 +155,7 @@ if (common.isWindows) {
// https://github.com/nodejs/node/issues/1691
process.chdir(fixtures.fixturesDir);
childProcess.exec(
`"${nodeBinary}" --expose_natives_as=v8natives --require ` +
`"${nodeBinary}" --require ` +
`"${fixtures.path('cluster-preload.js')}" cluster-preload-test.js`,
function(err, stdout, stderr) {
assert.ifError(err);

0 comments on commit 5a5bc58

Please sign in to comment.
You can’t perform that action at this time.