Skip to content

Commit 5cf5ab1

Browse files
BridgeARevanlucas
authored andcommitted
benchmark: (buffers) use destructuring
PR-URL: #18250 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 71faa5c commit 5cf5ab1

23 files changed

+57
-108
lines changed

benchmark/buffers/buffer-base64-decode-wrapped.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ const bench = common.createBenchmark(main, {
66
n: [32],
77
});
88

9-
function main(conf) {
10-
const n = +conf.n;
9+
function main({ n }) {
1110
const charsPerLine = 76;
1211
const linesCount = 8 << 16;
1312
const bytesCount = charsPerLine * linesCount / 4 * 3;

benchmark/buffers/buffer-base64-decode.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ const bench = common.createBenchmark(main, {
66
n: [32],
77
});
88

9-
function main(conf) {
10-
const n = +conf.n;
9+
function main({ n }) {
1110
const s = 'abcd'.repeat(8 << 20);
1211
// eslint-disable-next-line no-unescaped-regexp-dot
1312
s.match(/./); // Flatten string.

benchmark/buffers/buffer-base64-encode.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ const bench = common.createBenchmark(main, {
2727
n: [32]
2828
});
2929

30-
function main(conf) {
31-
const n = +conf.n;
32-
const len = +conf.len;
30+
function main({ n, len }) {
3331
const b = Buffer.allocUnsafe(len);
3432
let s = '';
3533
let i;

benchmark/buffers/buffer-bytelength.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,7 @@ const chars = [
1515
'𠜎𠜱𠝹𠱓𠱸𠲖𠳏𠳕𠴕𠵼𠵿𠸎𠸏𠹷𠺝𠺢' // 4 bytes
1616
];
1717

18-
function main(conf) {
19-
const n = conf.n | 0;
20-
const len = conf.len | 0;
21-
const encoding = conf.encoding;
22-
18+
function main({ n, len, encoding }) {
2319
var strings = [];
2420
var results;
2521
if (encoding === 'buffer') {

benchmark/buffers/buffer-compare-instance-method.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,8 @@ const bench = common.createBenchmark(main, {
77
millions: [1]
88
});
99

10-
function main(conf) {
11-
const iter = (conf.millions >>> 0) * 1e6;
12-
const size = (conf.size >>> 0);
13-
const args = (conf.args >>> 0);
10+
function main({ millions, size, args }) {
11+
const iter = millions * 1e6;
1412
const b0 = Buffer.alloc(size, 'a');
1513
const b1 = Buffer.alloc(size, 'a');
1614
const b0Len = b0.length;

benchmark/buffers/buffer-compare-offset.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,11 @@ function compareUsingOffset(b0, b1, len, iter) {
2323
bench.end(iter / 1e6);
2424
}
2525

26-
function main(conf) {
27-
const iter = (conf.millions >>> 0) * 1e6;
28-
const size = (conf.size >>> 0);
29-
const method =
30-
conf.method === 'slice' ? compareUsingSlice : compareUsingOffset;
31-
method(Buffer.alloc(size, 'a'),
32-
Buffer.alloc(size, 'b'),
33-
size >> 1,
34-
iter);
26+
function main({ millions, size, method }) {
27+
const iter = millions * 1e6;
28+
const fn = method === 'slice' ? compareUsingSlice : compareUsingOffset;
29+
fn(Buffer.alloc(size, 'a'),
30+
Buffer.alloc(size, 'b'),
31+
size >> 1,
32+
iter);
3533
}

benchmark/buffers/buffer-compare.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,8 @@ const bench = common.createBenchmark(main, {
2727
millions: [1]
2828
});
2929

30-
function main(conf) {
31-
const iter = (conf.millions >>> 0) * 1e6;
32-
const size = (conf.size >>> 0);
30+
function main({ millions, size }) {
31+
const iter = millions * 1e6;
3332
const b0 = Buffer.alloc(size, 'a');
3433
const b1 = Buffer.alloc(size, 'a');
3534

benchmark/buffers/buffer-concat.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,11 @@ const bench = common.createBenchmark(main, {
88
n: [1024]
99
});
1010

11-
function main(conf) {
12-
const n = +conf.n;
13-
const size = +conf.pieceSize;
14-
const pieces = +conf.pieces;
15-
11+
function main({ n, pieces, pieceSize, withTotalLength }) {
1612
const list = new Array(pieces);
17-
list.fill(Buffer.allocUnsafe(size));
13+
list.fill(Buffer.allocUnsafe(pieceSize));
1814

19-
const totalLength = conf.withTotalLength ? pieces * size : undefined;
15+
const totalLength = withTotalLength ? pieces * pieceSize : undefined;
2016

2117
bench.start();
2218
for (var i = 0; i < n * 1024; i++) {

benchmark/buffers/buffer-creation.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,8 @@ const bench = common.createBenchmark(main, {
1515
n: [1024]
1616
});
1717

18-
function main(conf) {
19-
const len = +conf.len;
20-
const n = +conf.n;
21-
switch (conf.type) {
18+
function main({ len, n, type }) {
19+
switch (type) {
2220
case '':
2321
case 'fast-alloc':
2422
bench.start();

benchmark/buffers/buffer-from.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ const bench = common.createBenchmark(main, {
1818
n: [2048]
1919
});
2020

21-
function main(conf) {
22-
const len = +conf.len;
23-
const n = +conf.n;
24-
21+
function main({ len, n, source }) {
2522
const array = new Array(len).fill(42);
2623
const arrayBuf = new ArrayBuffer(len);
2724
const str = 'a'.repeat(len);
@@ -31,7 +28,7 @@ function main(conf) {
3128

3229
var i;
3330

34-
switch (conf.source) {
31+
switch (source) {
3532
case 'array':
3633
bench.start();
3734
for (i = 0; i < n * 1024; i++) {

0 commit comments

Comments
 (0)