Skip to content

Commit 5d34f2f

Browse files
jasnellMylesBorins
authored andcommitted
benchmark: improve http2 benchmark configs
PR-URL: #16239 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 9aa5d49 commit 5d34f2f

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

benchmark/http2/headers.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ const PORT = common.PORT;
66
const bench = common.createBenchmark(main, {
77
n: [1e3],
88
nheaders: [0, 10, 100, 1000],
9-
}, { flags: ['--no-warnings'] });
9+
benchmarker: ['h2load']
10+
}, { flags: ['--no-warnings', '--expose-http2'] });
1011

1112
function main(conf) {
1213
const n = +conf.n;

benchmark/http2/respond-with-fd.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ const file = path.join(path.resolve(__dirname, '../fixtures'), 'alice.html');
1010
const bench = common.createBenchmark(main, {
1111
requests: [100, 1000, 10000, 100000, 1000000],
1212
streams: [100, 200, 1000],
13-
clients: [1, 2]
14-
}, { flags: ['--no-warnings'] });
13+
clients: [1, 2],
14+
benchmarker: ['h2load']
15+
}, { flags: ['--no-warnings', '--expose-http2'] });
1516

1617
function main(conf) {
1718

benchmark/http2/simple.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ const file = path.join(path.resolve(__dirname, '../fixtures'), 'alice.html');
1111
const bench = common.createBenchmark(main, {
1212
requests: [100, 1000, 10000, 100000],
1313
streams: [100, 200, 1000],
14-
clients: [1, 2]
15-
}, { flags: ['--no-warnings'] });
14+
clients: [1, 2],
15+
benchmarker: ['h2load']
16+
}, { flags: ['--no-warnings', '--expose-http2'] });
1617

1718
function main(conf) {
1819
const n = +conf.requests;

benchmark/http2/write.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ const PORT = common.PORT;
66
const bench = common.createBenchmark(main, {
77
streams: [100, 200, 1000],
88
length: [64 * 1024, 128 * 1024, 256 * 1024, 1024 * 1024],
9-
size: [100000]
10-
}, { flags: ['--no-warnings'] });
9+
size: [100000],
10+
benchmarker: ['h2load']
11+
}, { flags: ['--no-warnings', '--expose-http2'] });
1112

1213
function main(conf) {
1314
const m = +conf.streams;

0 commit comments

Comments
 (0)